Add support for opening or printing of multiple reports
ClosedPublic
Actions

Authored by habacker on Nov 15 2018, 8:39 PM.

Details

Reviewers

Commits

Summary

In the report overview select multiple reports and select one of the
available entries in the context menu opened with right mouse click.

BUG:401080
FIXED-IN:4.8.3

Test Plan

compiled and tested on linux

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

habacker requested review of this revision.Nov 15 2018, 8:39 PM

habacker created this revision.

kmymoney/views/kreportsview.cpp
1078	`items.isEmpty()` is more readable than `items.size() == 0`.
1101	`items.at(0)`is not correct here. Should be `tocItems.at(0)`
1125–1148	another candidate for `isEmpty()`
1139	one more candidate for `isEmpty()`

tbaumgart requested changes to this revision.Nov 28 2018, 7:57 PM

This revision now requires changes to proceed.Nov 28 2018, 7:57 PM

habacker marked 4 inline comments as done.Nov 29 2018, 7:15 AM

This revision is now accepted and ready to land.Nov 29 2018, 7:24 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kmymoney/views/kreportsview.h (1 line)
M			kmymoney/views/kreportsview.cpp (76 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45549	6c5cce7		Nov 15 2018, 8:39 PM	★	★
Diff 2	46449	bbc6099	- use isEmpty()	Nov 29 2018, 7:15 AM	★	★
Diff 3	46451	bbc6099	R261:bf6278f923ca1307a229c9ca1e8b206a4b82f400	Nov 29 2018, 7:30 AM	★	★