Differential D16800

Set tray icon visible only inbox messages
AbandonedPublic
Actions

Authored by ypashkovsky on Nov 10 2018, 12:24 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Summary

I don't know why my bug report was closed, maybe some misunderstood took place.
BUG: 400859
Anyway appearing tray icon when I get spam message is unnecessary IMO

See also: https://phabricator.kde.org/D16799 (this PR depends on it)

Diff Detail

Repository
R206 KMail
Lint
Lint Skipped
Unit
Unit Tests Skipped
ypashkovsky created this revision.Nov 10 2018, 12:24 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 10 2018, 12:24 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ypashkovsky requested review of this revision.Nov 10 2018, 12:24 PM

I also think some methods of this class should be renamed. (excludeFolder -> excludeFolderUnreadInbox)

ypashkovsky updated this revision to Diff 45237.Nov 10 2018, 2:07 PM
ypashkovsky retitled this revision from BUG: 400859 set tray icon visible only inbox messages to Set tray icon visible only inbox messages.
ypashkovsky edited the summary of this revision. (Show Details)

parentCollection returns copy, I don't think it's good.

mlaurent requested changes to this revision.Nov 11 2018, 8:52 AM
mlaurent added a subscriber: mlaurent.

Nope sorry I have a pop3 folder and I have some folder outside inbox child.
So this patch is not correct.

This revision now requires changes to proceed.Nov 11 2018, 8:52 AM
ypashkovsky added a comment.Nov 11 2018, 9:33 AM

A, I found there is a tick in folder settings called "Notify about new messages". Seems to work

ypashkovsky abandoned this revision.Nov 11 2018, 9:33 AM

Revision Contents
Changeset List

PathPackages
Msrc/unityservicemanager.cpp (13 lines)

Diff 45237

View Options

src/unityservicemanager.cpp

Loading...