Differential D16799

fixing inbox detection
ClosedPublic
Actions

Authored by ypashkovsky on Nov 10 2018, 12:11 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Commits
R92:013e1997ad9d: fixing inbox detection
Summary

BUG: 400859
Yandex remote box has name |INBOX and it was not detected as inbox

Diff Detail

Repository
R92 PIM: Common Mail Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ypashkovsky created this revision.Nov 10 2018, 12:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 10 2018, 12:11 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ypashkovsky requested review of this revision.Nov 10 2018, 12:11 PM
pino added a subscriber: pino.Nov 10 2018, 12:31 PM
pino added inline comments.
src/kernel/mailkernel.cpp
373

This looks too broad to me. For example, if I have a folder called "linboxes", then it will be wrongly recognized as inbox now.

I'm not a PIM developer, but IMHO the solution is to add yet another particular case here.

pino added a comment.Nov 10 2018, 12:55 PM

Also: the BUG: NNN ought to be in a new line on its own, not in the title of the commit (i.e. the first line).

ypashkovsky updated this revision to Diff 45236.Nov 10 2018, 1:53 PM
ypashkovsky retitled this revision from BUG: 400859 fixing inbox detection to fixing inbox detection.
ypashkovsky edited the summary of this revision. (Show Details)

added particular case

mlaurent accepted this revision.Nov 11 2018, 8:44 AM
mlaurent added a subscriber: mlaurent.

ok if there is this name ok.

This revision is now accepted and ready to land.Nov 11 2018, 8:44 AM
ypashkovsky added a comment.Nov 11 2018, 9:35 AM

I'm newbie to phabricator. Do I need to perform some actions to make this patch appear in master?

mlaurent added a comment.Nov 11 2018, 10:08 AM

you don't have commit access I will do it for you.
Thanks

Closed by commit R92:013e1997ad9d: fixing inbox detection (authored by mlaurent). · Explain WhyNov 11 2018, 10:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kernel/mailkernel.cpp (3 lines)

Diff 45271

View Options

src/kernel/mailkernel.cpp

Loading...