Differential D16467

Improve "No devices" warning
ClosedPublic
Actions

Authored by alexkovrigin on Oct 27 2018, 6:51 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Commits
R224:4daf129cf3fe: Improve "No devices" warning
Summary

Move the "No devices available" text in smsapp from combobox to the ConversationList.

P.S.
It's a GCI task.

Test Plan
  • Build and run smsapp
  • Try pairing and unpairing the device
  • See the difference

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexkovrigin created this revision.Oct 27 2018, 6:51 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptOct 27 2018, 6:51 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
alexkovrigin requested review of this revision.Oct 27 2018, 6:51 PM
sredman accepted this revision.Oct 27 2018, 8:48 PM
sredman added a subscriber: sredman.

Looks nice! There is a graphical problem if conversations were visible before the device connected, but that situation has other problems already on my to-fix list. Thank you!

This revision is now accepted and ready to land.Oct 27 2018, 8:48 PM
Closed by commit R224:4daf129cf3fe: Improve "No devices" warning (authored by alexkovrigin, committed by sredman). · Explain WhyOct 27 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/ConversationList.qml (7 lines)

Diff 44330

View Options

smsapp/qml/ConversationList.qml

Loading...