This adds a simple context menu to the statusbar; the only option it has is "Hide", which obviously hides the statusbar the same way as if you were to go the view menu.
Update:
Name: Patrick Flynn
Email: patrick_dev2000@outlook.com
Details
Details
- Reviewers
drosca - Commits
- R875:6d445edb44a8: Context menu for statusbar
Diff Detail
Diff Detail
- Repository
- R875 Falkon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Made changes to fix the leak and to simplify the code. Also fixed formatting to match coding conventions.
Comment Actions
The patch doesn't apply:
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16158.
Checking patch src/lib/other/statusbar.cpp...
error: while searching for:
void StatusBar::mousePressEvent(QMouseEvent *event)
{
if (event->button()==Qt::RightButton) {
QMenu *context = new QMenu;
QAction *hide_bar = new QAction(tr("Hide"),this);
connect(hide_bar,&QAction::triggered,m_window,&BrowserWindow::toggleShowStatusBar);
context->addAction(hide_bar);
context->exec(QCursor::pos());
}
QStatusBar::mousePressEvent(event);
error: patch failed: src/lib/other/statusbar.cpp:245
Applying patch src/lib/other/statusbar.cpp with 1 reject...
Rejected hunk #1.Please update patch against master HEAD, instead of differences between from your first patch version.
Comment Actions
Ok, I believe I fixed the issue, it should reflect the latest changes versus the master HEAD.