Differential D16076

load icons from proper icon themes
ClosedPublic
Actions

Authored by mart on Oct 9 2018, 3:55 PM.

Details

Reviewers
None
Group Reviewers
Kirigami
Commits
R169:6a45d5592acf: load icons from proper icon themes
Summary

this renders Kirigami.Icon and internal QQC2 icon loading mechanism
compatible, as creating a valid theme, QIconLoader will work.

Test Plan

on android the gallery loads both icons in Kirigami.Icon and in
QQC2 ToolButtons

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Oct 9 2018, 3:55 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptOct 9 2018, 3:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Oct 9 2018, 3:55 PM
mart edited the summary of this revision. (Show Details)Oct 9 2018, 3:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 9 2018, 4:01 PM
Closed by commit R169:6a45d5592acf: load icons from proper icon themes (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 43229