Differential D15962

pop3: qualify all mails for deletion if supplied id == -1
ClosedPublic
Actions

Authored by nowicki on Oct 5 2018, 10:23 AM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R44:647eb5029913: Qualify all POP3 mails for deletion if supplied id == -1
Summary

When determining ids of mails to delete a special identifier -1 is used to reference all e-mails. When the "leave on server" flag is not set asking for deletion of all mails should really return a list of all mail ids.

This fixes Pop3Test::testSimpleLeaveOnServer test case.

This patch is an effort to fix some POP3 autotests. I'm not deeply familiar with the POP3 resource, but the change seems logical.

Test Plan

Execute pop3 autotest.

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nowicki created this revision.Oct 5 2018, 10:23 AM
Restricted Application added a subscriber: kde-pim. · View Herald TranscriptOct 5 2018, 10:23 AM
nowicki requested review of this revision.Oct 5 2018, 10:23 AM
dvratil accepted this revision.Oct 5 2018, 11:08 AM
dvratil added a subscriber: dvratil.

Looks sensible. Thanks.

This revision is now accepted and ready to land.Oct 5 2018, 11:08 AM
Closed by commit R44:647eb5029913: Qualify all POP3 mails for deletion if supplied id == -1 (authored by nowicki). · Explain WhyOct 5 2018, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mresources/pop3/pop3resource.cpp (2 lines)

Diff 42946

View Options

resources/pop3/pop3resource.cpp

Loading...