When running the konsole unit tests on a system where the
language setting is not English the test
ProfileTest::testFallbackProfile fails because
it compares the translated value of the Name property
with the string literal "Default". To fix the test we can
use `UntranslatedName' instead.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:67b8c3f8dc1d: Fix system language dependent unit test
- Run the konsole unit tests on a system where the language is not English
Output of ctest --verbose before the fix:
8: FAIL! : Konsole::ProfileTest::testFallbackProfile() Compared values are not the same 8: Actual (fallback->property<QString>(Profile::Name)): "Standard" 8: Expected (QStringLiteral("Default")) : "Default" 8: Loc: [/var/run/media/peter/MEDIA/Projects/kde/konsole/src/autotests/ProfileTest.cpp(237)]
After the fix all tests should pass.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.