Differential D15588

Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags
ClosedPublic
Actions

Authored by mlaurent on Sep 18 2018, 11:39 AM.

Tags

None

Subscribers

Details

Reviewers

Commits

R255:974cabed3b1f: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags
R255:9587320cfcb7: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags

Summary

Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent requested review of this revision.Sep 18 2018, 11:39 AM

mlaurent created this revision.

Harbormaster completed remote builds in B2988: Diff 41895.Sep 18 2018, 11:39 AM

mlaurent added a reviewer: mgallien.Sep 18 2018, 11:39 AM

mgallien added a comment.Sep 19 2018, 3:43 PM

This comment was removed by mgallien.

Thanks for your help.
Sorry for the noise with the wrong comment.
Please fix one inline comment.

src/elisaapplication.cpp
414	Can you make it d->mAudioControl.->setPlayerPlaybackState in case it is possible ?

This revision now requires changes to proceed.Sep 19 2018, 3:57 PM

Fix comment

Harbormaster completed remote builds in B3021: Diff 41957.Sep 20 2018, 4:51 AM

mgallien accepted this revision.Sep 20 2018, 5:07 AM

This revision is now accepted and ready to land.Sep 20 2018, 5:07 AM

Closed by commit R255:9587320cfcb7: Fix compile with QT_NO_NARROWING_CONVERSIONS_IN_CONNECT flags (authored by mlaurent). · Explain WhySep 20 2018, 5:45 AM

This revision was automatically updated to reflect the committed changes.

Is this needed in the 0.3 branch now?

With latest frameworks (ECM) master changes, both Neon and Kubuntu CI stable 0.3 branch builds fail.

https://build.neon.kde.org/job/bionic_stable_extras_elisa_bin_amd64/34/consoleFull

https://launchpad.net/~kubuntu-ci/+archive/ubuntu/stable/+build/15483110/+files/buildlog_ubuntu-cosmic-amd64.elisa_0.2.80+p18.10+git20180924.2006-0_BUILDING.txt.gz

If it's failed yep indeed you need to add this patch.

Revision Contents
Changeset List

			Path	Packages
M			src/audiowrapper.h (2 lines)
M			src/audiowrapper.cpp (2 lines)
M			src/elisaapplication.cpp (5 lines)
M			src/manageaudioplayer.h (20 lines)
M			src/manageaudioplayer.cpp (12 lines)

Diff 41958

src/audiowrapper.h

Loading...

src/audiowrapper.cpp

Loading...

src/elisaapplication.cpp

Loading...

src/manageaudioplayer.h

Loading...

src/manageaudioplayer.cpp

Loading...