Improve command entry's prompt animation
ClosedPublic

Authored by sirgienko on Sep 13 2018, 8:13 PM.

Details

Summary

Improve realization and logic in command entry's prompt item animations.

  • Disable background colour manipulation
  • Set colour for Queued status similar to another statuses.
  • Change animation realization: from QTimer to QPropertyAnimation: simpler and convenient

Also disable setting queued status for expression, which we run immediatly

This commit also fix problem with QPropertyAnimation warnings (in short: we start animation, and immideatly remove animated object in qDeleteAll, of couse before animation finished)

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sirgienko created this revision.Sep 13 2018, 8:13 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 13 2018, 8:13 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Sep 13 2018, 8:13 PM
sirgienko updated this revision to Diff 41580.Sep 13 2018, 8:14 PM

Don't start prompt animation, if user disable animations at all.

asemke accepted this revision.Sep 15 2018, 7:29 AM
This revision is now accepted and ready to land.Sep 15 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.