Differential D1536

unit test for lineeditwithkeywords
ClosedPublic
Actions

Authored by grebois on May 4 2016, 11:13 AM.

Details

Reviewers
mlaurent
bensi
ervin
Summary

all tests passed
i use qverify and qcompare but i don't know what is better.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
grebois updated this revision to Diff 3636.May 4 2016, 11:13 AM
grebois retitled this revision from to unit test for lineeditwithkeywords.
grebois updated this object.
grebois edited the test plan for this revision. (Show Details)
grebois added reviewers: mlaurent, bensi, ervin.
grebois added a project: KDE PIM: KMail.
grebois added a subscriber: hrouis.
grebois updated this revision to Diff 3680.May 6 2016, 9:19 PM

update taking into consideration kevin's points about the irc

just for QMetaObject::invokeMethod(lineEdit, "slotClearHistory");
i changed lineEdit by &lineEdit, it's work like that, all test passed. Is it an error ?

mlaurent added inline comments.May 7 2016, 11:04 AM
pimcommon/src/widgets/autotests/CMakeLists.txt
2

messagelist ?:)

6

messagelist ?:)

grebois updated this revision to Diff 3685.May 7 2016, 11:29 AM

messagelist -> pimcommon_widget

mlaurent added inline comments.May 8 2016, 11:22 AM
pimcommon/src/widgets/autotests/lineeditwithkeywordstest.cpp
2

copyright

grebois updated this revision to Diff 3699.May 8 2016, 2:47 PM

copyright added

mlaurent accepted this revision.May 8 2016, 6:42 PM
mlaurent edited edge metadata.

+2 :)
Thanks

This revision is now accepted and ready to land.May 8 2016, 6:42 PM
mlaurent closed this revision.Mar 21 2018, 8:40 PM

Revision Contents
Changeset List

Diff 3699

View Options

pimcommon/src/widgets/autotests/CMakeLists.txt

Loading...
View Options

pimcommon/src/widgets/autotests/lineeditwithkeywordstest.cpp

Loading...