Support sell w/o asset account
ClosedPublic

Authored by tbaumgart on Sep 2 2018, 8:11 AM.

Details

Summary

Allow a sell operation that reduces the number of shares to pay fees.
This is to handle mutual fund account fees. There is no money
transferred -- only a reduction in shares.

BUG: 398133

Test Plan

I have tested entry and retrieval of the transaction. What needs to be tested how this change affects reporting. I can't do that.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tbaumgart requested review of this revision.Sep 2 2018, 8:11 AM
tbaumgart created this revision.

I have not tested this yet, but I do have one investment account that does this, and I just enter it as a normal sell transaction, with fees of the exact amount of the sale, so the final value of the transaction is zero. I suppose this would make entering that type of transaction easier/fewer steps. (I also think it might be used for equities other than mutual funds.) What I can't tell just looking at this Diff is whether this is to be a new type of transaction, or else how the user indicates that this is the case.

The user will not provide an account. The Enter button is enabled in this case only if the transaction balance is zero. No special transaction type needed.

Other than allowing the transaction to be saved without specifying a brokerage account, what would need to be tested? Maybe I'm not sufficiently paranoid, but what effects on reporting are you considering possible>?

kmymoney/dialogs/investactivities.cpp
466–468

Perhaps reword to say "Allow a sell operation to be saved without specifying a brokerage account, when the proceeds equal the fees . This will handle sales made solely to cover annual account fees, where there is no money transferred." (I tried entering with "//" but all but one of them got removed.)

tbaumgart updated this revision to Diff 50316.Jan 26 2019, 1:19 PM
tbaumgart marked an inline comment as done.
  • Improved comment
This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2019, 1:23 PM
This revision was automatically updated to reflect the committed changes.