add isInternal to Expression
ClosedPublic
Actions

Authored by sirgienko on Aug 29 2018, 9:51 PM.

Details

Reviewers

asemke
filipesaraiva

Summary

Remove setInternal() function from Expression, and add isInternal flag to Expression constructor and to evaluateExpression(for forward passing to Expression constructor)

Diff Detail

Repository

R55 Cantor

Branch

add-isInternal-to-Expression

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2377
Build 2395: arc lint + arc unit

sirgienko created this revision.Aug 29 2018, 9:51 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 29 2018, 9:51 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

sirgienko requested review of this revision.Aug 29 2018, 9:51 PM

Harbormaster completed remote builds in B2340: Diff 40668.Aug 29 2018, 9:51 PM

This makes sense. But let's unify and simplify the parameter naming a bit and let's call the additional new parameter in the constructor simply "internal". The parameter is called "internal" and the functions to get and to set it are called isInternal() and setInternal(), respectively. This would also be similar to the current naming in Session::setInternal().

Change flag name from isInternal to internal

Harbormaster completed remote builds in B2377: Diff 40745.Aug 31 2018, 9:56 AM

Change member name from isInternal to internal

Harbormaster completed remote builds in B2396: Diff 40787.Aug 31 2018, 6:41 PM

asemke accepted this revision.Aug 31 2018, 7:21 PM

This revision is now accepted and ready to land.Aug 31 2018, 7:21 PM

filipesaraiva accepted this revision.Sep 1 2018, 10:39 AM

By a151904026aab6b54516c9c6a25904fd73de6aa9

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			src/backends/R/rexpression.h (2 lines)
M			src/backends/R/rexpression.cpp (2 lines)
M			src/backends/R/rsession.h (2 lines)
M			src/backends/R/rsession.cpp (4 lines)
M			src/backends/julia/juliaexpression.h (3 lines)
M			src/backends/julia/juliaexpression.cpp (4 lines)
M			src/backends/julia/juliasession.h (3 lines)
M			src/backends/julia/juliasession.cpp (5 lines)
M			src/backends/kalgebra/kalgebraexpression.h (2 lines)
M			src/backends/kalgebra/kalgebraexpression.cpp (4 lines)
M			src/backends/kalgebra/kalgebrasession.h (2 lines)
M			src/backends/kalgebra/kalgebrasession.cpp (5 lines)
M			src/backends/lua/luaexpression.h (2 lines)
M			src/backends/lua/luaexpression.cpp (4 lines)
M			src/backends/lua/luasession.h (2 lines)
M			src/backends/lua/luasession.cpp (4 lines)
M			src/backends/maxima/maximaexpression.h (2 lines)
M			src/backends/maxima/maximaexpression.cpp (2 lines)
M			src/backends/maxima/maximasession.h (2 lines)
M			src/backends/maxima/maximasession.cpp (10 lines)
M			src/backends/null/nullexpression.h (2 lines)
M			src/backends/null/nullexpression.cpp (2 lines)
M			src/backends/null/nullsession.h (2 lines)
M			src/backends/null/nullsession.cpp (4 lines)
M			src/backends/octave/octaveexpression.h (2 lines)
M			src/backends/octave/octaveexpression.cpp (2 lines)
M			src/backends/octave/octavesession.h (2 lines)
M			src/backends/octave/octavesession.cpp (4 lines)
M			src/backends/python/pythonexpression.h (2 lines)
M			src/backends/python/pythonexpression.cpp (2 lines)
M			src/backends/python/pythonsession.h (2 lines)
M			src/backends/python/pythonsession.cpp (4 lines)
M			src/backends/qalculate/qalculateexpression.h (2 lines)
M			src/backends/qalculate/qalculateexpression.cpp (4 lines)
M			src/backends/qalculate/qalculatesession.h (2 lines)
M			src/backends/qalculate/qalculatesession.cpp (4 lines)
M			src/backends/sage/sageexpression.h (2 lines)
M			src/backends/sage/sageexpression.cpp (2 lines)
M			src/backends/sage/sagesession.h (2 lines)
M			src/backends/sage/sagesession.cpp (4 lines)
M			src/backends/scilab/scilabexpression.h (2 lines)
M			src/backends/scilab/scilabexpression.cpp (2 lines)
M			src/backends/scilab/scilabsession.h (2 lines)
M			src/backends/scilab/scilabsession.cpp (4 lines)
M			src/lib/expression.h (21 lines)
M			src/lib/expression.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40668	4b53595		Aug 29 2018, 9:47 PM	★	★
Diff 2	40745	4b53595	Change flag name from `isInternal` to `internal`	Aug 31 2018, 9:56 AM	★	★
Diff 3	40787	4b53595	Change member name from isInternal to internal	Aug 31 2018, 6:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
799ff677d80a	85cb2938026e	4b53595321fc	Nikita Sirgienko	Remove setInternal() function from Expression, and add internal flag to… (Show More…)	Aug 29 2018, 9:45 PM

add isInternal to ExpressionClosedPublicActions

Details

Diff Detail

Showing Only Differences

Revision ContentsChangeset List

Diff 40745

src/backends/R/rexpression.h

src/backends/R/rexpression.cpp

src/backends/R/rsession.h

src/backends/R/rsession.cpp

src/backends/julia/juliaexpression.h

src/backends/julia/juliaexpression.cpp

src/backends/julia/juliasession.h

src/backends/julia/juliasession.cpp

src/backends/kalgebra/kalgebraexpression.h

src/backends/kalgebra/kalgebraexpression.cpp

src/backends/kalgebra/kalgebrasession.h

src/backends/kalgebra/kalgebrasession.cpp

src/backends/lua/luaexpression.h

src/backends/lua/luaexpression.cpp

src/backends/lua/luasession.h

src/backends/lua/luasession.cpp

src/backends/maxima/maximaexpression.h

src/backends/maxima/maximaexpression.cpp

src/backends/maxima/maximasession.h

src/backends/maxima/maximasession.cpp

src/backends/null/nullexpression.h

src/backends/null/nullexpression.cpp

src/backends/null/nullsession.h

src/backends/null/nullsession.cpp

src/backends/octave/octaveexpression.h

src/backends/octave/octaveexpression.cpp

src/backends/octave/octavesession.h

src/backends/octave/octavesession.cpp

src/backends/python/pythonexpression.h

src/backends/python/pythonexpression.cpp

src/backends/python/pythonsession.h

src/backends/python/pythonsession.cpp

src/backends/qalculate/qalculateexpression.h

src/backends/qalculate/qalculateexpression.cpp

src/backends/qalculate/qalculatesession.h

src/backends/qalculate/qalculatesession.cpp

src/backends/sage/sageexpression.h

src/backends/sage/sageexpression.cpp

src/backends/sage/sagesession.h

src/backends/sage/sagesession.cpp

src/backends/scilab/scilabexpression.h

src/backends/scilab/scilabexpression.cpp

src/backends/scilab/scilabsession.h

src/backends/scilab/scilabsession.cpp

src/lib/expression.h

src/lib/expression.cpp

add isInternal to Expression
ClosedPublic
Actions

Revision Contents
Changeset List