Differential D14775

Added tests for QML Extension API
ClosedPublic
Actions

Authored by anmolgautam on Aug 12 2018, 5:51 PM.

Details

Reviewers
drosca
Commits
R875:1ca4a6791bb1: Added tests for QML Extension API

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anmolgautam requested review of this revision.Aug 12 2018, 5:51 PM
anmolgautam created this revision.
anmolgautam updated this revision to Diff 39540.Aug 12 2018, 5:52 PM
  • Merge branch 'master' into patch-qml-api-tests
drosca requested changes to this revision.Sep 2 2018, 8:37 PM
drosca added inline comments.
autotests/qml/qmlcookiesapitest.cpp
112

If this check doesn't pass then why it is there at all?
If you can't ensure the time will be identical then compare it with some tolerance (eg. 1s).

autotests/qml/qmlwindowsapitest.cpp
51

So is it correct or not?

This revision now requires changes to proceed.Sep 2 2018, 8:37 PM
anmolgautam updated this revision to Diff 55376.Apr 3 2019, 9:27 PM

corrected tests

anmolgautam marked 2 inline comments as done.Apr 3 2019, 9:27 PM
drosca accepted this revision.Apr 5 2019, 6:50 PM
This revision is now accepted and ready to land.Apr 5 2019, 6:50 PM
Closed by commit R875:1ca4a6791bb1: Added tests for QML Extension API (authored by anmolgautam). · Explain WhyApr 6 2019, 4:42 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 18 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 55578

View Options

autotests/CMakeLists.txt

Loading...
View Options

autotests/qml/qmlcookiesapitest.cpp

Loading...
View Options

autotests/qml/qmlwindowsapitest.cpp

Loading...