const

In previous revision I said that I want this (enabled plugins settings in sqlite database) moved to separate revision. Or even to remove it and make it stored in QSettings, because right I don't really see a reason to have it in database.

QStringLiteral (QSL)

It leaks here, nothing will ever delete it. HistoryEntry is meant to be passed by value.

If this is false it will return HistoryEntry with not initialized member variables.

QList<HistoryEntry*>

just remove(0, 4), or better mid(4).

Why is it duplicated there?

What is identity?

override

override

QQmlComponent *

QQmlComponent *

So this was discussed in the previous review and the outcome was that it will not work like that, and it must pass QJSValue in the signal. Am I correct?

QStringLiteral

const + QStringLiteral

Empty destructor is not needed

QL1S("/") -> QL1C('/')

initialization

You should be able to disconnect all with m_webTab->disconnect(this) (test first!)

Some classes are exported and some not, so which way is it? It should not be needed to export any QML support classes, as there is no reason for C++ plugins to use them.

The only issue might be with tests, but it doesn't seem to be used there.

If you want to show this warning then it should have the windowId that wasn't found, otherwise it's just useless.

This is only for the WindowState enum? In that case it would be better to create class Enums and move all these "standalone" enums there. It will also look better from QML side: instead of "Falkon.WindowState.WindowState.FullScreen" -> "Falkon.Enums.WindowState.FullScreen".

Use QQuickWidget instead.

#if HAVE_LIBINTL because HAVE_LIBINTL is defined always.

extra newline

[this] { space

QStringLiteral

reason (last parameter) is QString, so it should use QStringLiteral. Or just leave it empty with QString().

The entire logic here is wrong too, you will never get cache hit because HistoryEntry is only ever created from the QML support code. It should use the HistoryEntry contents as key, not address.

const-ref

It should be #cmakedefine01 HAVE_LIBINTL.

Same issue here, nothing will delete it.

It must be requestStarted(const QJSValue &request).

const HistoryEntry &entry

This should return nullptr. Again did you test it?

You should use QQuickWidget instead of QWidget::createWindowContainer.

?

const-ref

QSL

These translations changes are unrelated and should not be here.