Differential D14725

Add hertz script (extract rental car info)
ClosedPublic
Actions

Authored by mlaurent on Aug 10 2018, 11:12 AM.

Details

Reviewers
vkrause
Commits
R1003:006a95a6d37c: Add hertz script (extract rental car info)
Summary

Allow to extract hertz rental info

Test Plan

Using kmail for showing result + use extractortest

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Aug 10 2018, 11:12 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 10 2018, 11:12 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent requested review of this revision.Aug 10 2018, 11:12 AM
mlaurent added a reviewer: vkrause.Aug 10 2018, 11:12 AM
mlaurent added inline comments.
src/extractors/hertz.js
87

I don't have idea how to extract this date/time.
If you have an idea :)

mlaurent updated this revision to Diff 39404.Aug 10 2018, 11:18 AM
  • Remove comment + add name
vkrause added inline comments.Aug 10 2018, 11:18 AM
src/extractors/hertz.js
87

Skip the day name as part of the regexp, and then use format "dd MMM yyyy hh:mm A" with "en" locale should work I think. Maybe even keeping the day name and adding "ddd " to the format, never tried that.

mlaurent updated this revision to Diff 39410.Aug 10 2018, 1:25 PM
  • Fix extract date/time
vkrause accepted this revision.Aug 11 2018, 7:43 PM
This revision is now accepted and ready to land.Aug 11 2018, 7:43 PM
Closed by commit R1003:006a95a6d37c: Add hertz script (extract rental car info) (authored by mlaurent). · Explain WhyAug 12 2018, 7:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39494

View Options

src/extractors/extractors.qrc

Loading...
View Options

src/extractors/hertz.js

Loading...
View Options

src/extractors/hertz.json

Loading...