Turn qqc2-desktop-style in a proper Qt plugin
AcceptedPublic

Authored by lepagevalleeemmanuel on Aug 8 2018, 1:52 PM.

Details

Reviewers
mart
Summary

Add support for static Qt plugins.

This style can now replace the default style in applications built
with the static Qt SDK. It allows better encapsulation on the desktop
and makes it easier to try applications on Plasma Mobile.

  • Remove dead code **

There was an unused class

  • Gnerate a QML QRC at build-time **

Since commit d0e3daafdbd, all QML files are now preprocessed. This
renders the QRC file introduced in a few commits ago invalid since
it uses the non-preprocessed files.

The commit also reorder the CMake targets to make sure the files
are preprecessed before the plugin is built.

  • Rename org.kde.qqc2desktopstyle.private to org.kde.desktop.private **

Submodules are supposed to have a consistent URI

  • Add an option to enable or disable plasma integration. **

The way the plugin is built is incompatible with static AppImage and
probably other self contained file format.

  • Use the same coding style for all "private" import **

First, there was a typo in my previous commit. But the main problem
was that even like that, mixing org.kde.desktop/private,
org.kde.desktop.private and "private" is not very portable when
switching between static and dynamic mode.

Test Plan

Not much. Works for me. It will need other users to validate it didn't regress anything for them. I would suggest not merging this as-is

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2018, 1:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
lepagevalleeemmanuel requested review of this revision.Aug 8 2018, 1:52 PM
mart accepted this revision.Nov 23 2018, 2:52 PM
This revision is now accepted and ready to land.Nov 23 2018, 2:52 PM