Differential D14670

Fix an undefined reference error with static mode + LTO
ClosedPublic
Actions

Authored by lepagevalleeemmanuel on Aug 7 2018, 12:34 PM.

Details

Reviewers
mart
Commits
R169:e1620cba164b: Fix the build in LTO static mode
Summary

This patch is generally useful to fix:

/tmp/ccEVEKCP.ltrans21.ltrans.o:<artificial>:function KirigamiPlugin::registerTypes(char const*)::{lambda(QQmlEngine*, QJSEngine*)#8}::_FUN(QQmlEngine*, QJSEngine*): error: undefined reference to 'Kirigami::TabletModeWatcher::self()'

It does not however fix the tablet mode itself, it justs make it past this specific error.

Test Plan

It didn't compile before and it compiled after

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lepagevalleeemmanuel requested review of this revision.Aug 7 2018, 12:34 PM
lepagevalleeemmanuel created this revision.
mart accepted this revision.Aug 7 2018, 12:35 PM
This revision is now accepted and ready to land.Aug 7 2018, 12:35 PM
Closed by commit R169:e1620cba164b: Fix the build in LTO static mode (authored by lepagevalleeemmanuel). · Explain WhyAug 7 2018, 12:39 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 7 2018, 12:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
Msrc/CMakeLists.txt (1 line)

Diff 39251

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...