I added 2 new buttons, a resume and a pause button.
FEATURE: 227710
Before:
After:
Details
Details
Diff Detail
Diff Detail
- Repository
- R360 KTeaTime
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/toplevel.cpp | ||
|---|---|---|
| 366 | Why do you need m_pausedTea, you don't overwrite m_runningTea here so when we go back to resumeTea it'll be fine and doesn't need restoring, no? | |
| src/toplevel.cpp | ||
|---|---|---|
| 366 | Yes, indeed. I removed it. | |
Comment Actions
i'm not very happy with m_remainingTeaTime as a variable name, because to me it doesn't say "this is only for when it's paused", maybe m_pausedRemainingTeaTime?
Comment Actions
Looks good, to me, since it seems to me you're serious in being a KDE Developer, i think you should get a Developer account
https://community.kde.org/Infrastructure/Get_a_Developer_Account
Of course this doesn't mean you skip reviews (unless it's a very trivial patch) but makes it easier for me since i then can say "looks good to me" and you commit it to git, instead of me commiting it :D
Does that sound ok to you? I guess you know how to use git just fine
Comment Actions
I see you've requested your account.
Feel free to commit this once you've got access.
Don't hesitate to ask if you have questions.