Differential D14292

Fix translated labels text cropping.
ClosedPublic
Actions

Authored by ppavel on Jul 23 2018, 10:03 AM.

Details

Reviewers
dakon
Commits
R358:72c981bcce2b: Fix translated labels text cropping in kgpgfirstassistant.
Summary

Translated text is displayed as cropped. See picture.

Test Plan

Run kgpg on unconfigured environment with russian localization.
See kfirstassistantdialog.
Click Next on first page.
See if text is displayed as cropped?

Diff Detail

Repository
R358 KGpg
Lint
Lint Skipped
Unit
Unit Tests Skipped
ppavel created this revision.Jul 23 2018, 10:03 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJul 23 2018, 10:03 AM
ppavel requested review of this revision.Jul 23 2018, 10:03 AM
dakon requested changes to this revision.Jul 24 2018, 5:05 AM

Thanks for the patch! Can you please do a patch without all these lambda changes? They don't make anything more readable, and they make reviewing much harder through lot of unrelated changes.

This revision now requires changes to proceed.Jul 24 2018, 5:05 AM
ppavel updated this revision to Diff 38301.Jul 24 2018, 7:23 AM

without lambdas ...

dakon requested changes to this revision.Jul 24 2018, 3:12 PM

The change is now without the "small refactoring" from the title. The indentation is tabs. Otherwise fine with me, destination will be 18.08 branch.

This revision now requires changes to proceed.Jul 24 2018, 3:12 PM
ppavel retitled this revision from Fix translated labels text cropping and small refactoring. to Fix translated labels text cropping..Jul 25 2018, 6:34 AM
ppavel edited the summary of this revision. (Show Details)
ppavel updated this revision to Diff 38380.Jul 25 2018, 7:11 AM

Indentation fixed.

ppavel added a comment.Jul 25 2018, 7:13 AM

no commit access.

dakon accepted this revision.Jul 25 2018, 4:58 PM

Please send a git diff directly to me, then I will apply this.

This revision is now accepted and ready to land.Jul 25 2018, 4:58 PM
Closed by commit R358:72c981bcce2b: Fix translated labels text cropping in kgpgfirstassistant. (authored by Pavel Akopov <pak@altlinux.org>, committed by dakon). · Explain WhyJul 28 2018, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkgpgfirstassistant.cpp (6 lines)

Diff 38301

View Options

kgpgfirstassistant.cpp

Loading...