Differential D13934

Don't rely on address formatting data from kdelibs4support
ClosedPublic
Actions

Authored by vkrause on Jul 7 2018, 5:56 PM.

Details

Reviewers
mlaurent
Commits
R174:e436281ef1d4: Don't rely on address formatting data from kdelibs4support
Summary

KContacts is the only user of this data according to lxr, so let's just
copy it here to outlive kdelibs4support. It's also in a Qt resource now,
so this is easier to deploy.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jul 7 2018, 5:56 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 7 2018, 5:56 PM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
vkrause requested review of this revision.Jul 7 2018, 5:56 PM
mlaurent accepted this revision.Jul 8 2018, 7:53 AM
This revision is now accepted and ready to land.Jul 8 2018, 7:53 AM
Closed by commit R174:e436281ef1d4: Don't rely on address formatting data from kdelibs4support (authored by vkrause). · Explain WhyJul 8 2018, 8:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/addresstest.cpp (12 lines)
Msrc/address.cpp (9 lines)
AMsrc/addressformatrc (149 lines)
Msrc/kcontacts.qrc (1 line)

Diff 37304

View Options

autotests/addresstest.cpp

Loading...
View Options

src/address.cpp

Loading...
View Options

src/addressformatrc

Loading...
View Options

src/kcontacts.qrc

Loading...