Add secondary commit hook for staging repos
very simple logic, is user scmupdate? allow everything, else just
phabricator tags creation
Also don't send out the any notifications at all.
Add phab arcconfig
Details
Details
- Reviewers
bcooksley - Maniphest Tasks
- Unknown Object (Maniphest Task)
- Commits
- R248:06ed163e8f5e: Add hook to sync repo to staging repository
R248:784797c3407c: Add script to sync to staging repo
R248:61e20d9ad8f8: Add hook to sync repo to staging repository
R248:2bf5ffae2452: Adjust how we mirror changes
none so far
Diff Detail
Diff Detail
- Repository
- R248 Repository management
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good, just a few small things to sort out.
| helpers/sync-staging.sh | ||
|---|---|---|
| 12 | The mirror option to Git, if memory serves, will destroy any refs that don't exist on the system making the push, which is probably not what we want here. I'd suggest taking a look at the Github replication script, which ignores special Github refs on the remote side, for this. | |
| hooks/update.secondary.staging | ||
| 54 | Leftover from original script? | |
| 55 | Shouldn't this be and? Otherwise only scmsync will be able to push. | |
| hooks/update.secondary.staging | ||
|---|---|---|
| 54 | Sorry, one more thing I missed... repository.ref_name is a little bit special in that it's the name of the branch/tag/etc which has been created, with repository.ref_type containing the type of ref (tag, branch, etc) which was changed. | |