This patch includes the following:
I have also pushed the code to histogram_vertical branch, you can check that out to test it.
| Lint Skipped |
| Unit Tests Skipped |
| src/backend/worksheet/plots/cartesian/Histogram.cpp | ||
|---|---|---|
| 155 | Use a std-setter class here defined via out macros to the the undo/redo-stuff. | |
| 157 | Once you switched to the std-setter, retransform() needs to be called, no need to emit this signal anymore. | |
| 161 | similar here, use std-setter. | |
| 172 | for the getters we also use macros. Check how all other getters are declared and defined. | |
| 176 | also here, use std-setter with retransform(), no need for this emit. | |
| 180 | also here, use std-setter with retransform(), no need for this emit. | |
| src/backend/worksheet/plots/cartesian/Histogram.h | ||
| 48 | HistorgramOrientation would be a better name or this enum, similar to AxisOrientation. | |
| src/backend/worksheet/plots/cartesian/Histogram.cpp | ||
|---|---|---|
| 157 | this will still need to be called as cartesian plot listens for this and autoscale axes based on this signal | |
| src/backend/worksheet/plots/cartesian/Histogram.cpp | ||
|---|---|---|
| 176 | I cannot make this change right now, firstly this is not changed by me right now. Also, it sets the data inside a struct, which would lead the std-setter to fail as it calls fieldnamechanged function inside it and here the field is something like histogramData.binsOption. | |
| 176 | I will make this change in another diff all together since it would need more refactoring | |