Fix color handling in kdav

Authored by ochurlaud on Jun 10 2018, 6:38 PM.



This fixes bug 395216.

I found out that colors of the form RGBA here handled as ARGB by QColor.

The colors are know shown correctly in korganizer;

It would be great if this could land in the next bug-fix release :)

BUG: 395216

Diff Detail

R490 KDAV Library
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ochurlaud created this revision.Jun 10 2018, 6:38 PM
Restricted Application added a subscriber: kde-pim. · View Herald TranscriptJun 10 2018, 6:38 PM
ochurlaud requested review of this revision.Jun 10 2018, 6:38 PM
dvratil added a subscriber: dvratil.EditedJun 11 2018, 12:48 AM

Wouldn't it be easier to just move the "AA" channel from the end of the string to the beginning where Qt expects it, and keep using QColor::setNamedColor()?

ochurlaud updated this revision to Diff 36018.Jun 11 2018, 6:17 PM
ochurlaud edited the summary of this revision. (Show Details)

Fix code as asked by @dvratil

dvratil accepted this revision.Jun 11 2018, 10:17 PM


This revision is now accepted and ready to land.Jun 11 2018, 10:17 PM
This revision was automatically updated to reflect the committed changes.
ochurlaud removed a subscriber: dvratil.Jun 12 2018, 7:06 PM

@dvratil: can you add this to the next bugfix patch ?