Differential D13385

Fix #394905
ClosedPublic
Actions

Authored by ralavizadeh on Jun 6 2018, 6:59 PM.

Details

Reviewers
drosca
Summary

Since Falkon Windows binary is compiled using MSVC2015 it is linked to Universal Windows 10 CRT. To run it on older versions of Windows a hotfix should be installed. This patch warns user to install that hotfix.

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
ralavizadeh created this revision.Jun 6 2018, 6:59 PM
Restricted Application added a project: Falkon. · View Herald TranscriptJun 6 2018, 6:59 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
ralavizadeh requested review of this revision.Jun 6 2018, 6:59 PM
ralavizadeh updated this revision to Diff 35702.Jun 6 2018, 7:03 PM

forgot to call function

drosca accepted this revision.Jun 6 2018, 7:04 PM

This should go to Falkon/3.0.

Also add to commit message:

BUG: 394905
FIXED-IN: 3.0.2
This revision is now accepted and ready to land.Jun 6 2018, 7:04 PM

Revision Contents
Changeset List

PathPackages
Mwindows/installer.nsi (18 lines)
Mwindows/strings.nsh (2 lines)

Diff 35702

View Options

windows/installer.nsi

Loading...
View Options

windows/strings.nsh

Loading...