Remove unused kreplacements bits
ClosedPublic
Actions

Authored by pino on Jun 5 2018, 7:02 AM.

Details

Reviewers

Commits

R983:e07b097de920: Remove unused kreplacements bits

Summary

Since kdiff3 does not seem to support a non-KDE build anymore, the
"kreplacements" bits are effectively unused. Hence, drop them, together
with the code snippets referring to them.

Test Plan

Builds fine.

Diff Detail

Repository

R983 KDiff3

Branch

remove-kreplacements (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

pino requested review of this revision.Jun 5 2018, 7:02 AM

pino created this revision.

Thanks for the much needed cleanup. I am open to having QT only builds but this would need to redone with qt5/kf5 in mind. Also without assuming QT-only = windows in places. If this works on windows go ahead.

mreeves accepted this revision.Jun 7 2018, 1:19 AM

This revision is now accepted and ready to land.Jun 7 2018, 1:19 AM

pino closed this revision.Jun 7 2018, 5:57 AM

Revision Contents
Changeset List

		Path
M		src/ccInstHelper.cpp (5 lines)
D	M	src/kreplacements/README (30 lines)
D	M	src/kreplacements/ShellContextMenu.h (60 lines)
D	M	src/kreplacements/ShellContextMenu.cpp (505 lines)
D	M	src/kreplacements/config-kdiff3.h (2 lines)
D	M	src/kreplacements/kaboutdata.h (2 lines)
D	M	src/kreplacements/kaccel.h (2 lines)
D	M	src/kreplacements/kaction.h (2 lines)
D	M	src/kreplacements/kactioncollection.h (2 lines)
D	M	src/kreplacements/kapplication.h (2 lines)
D	M	src/kreplacements/kcmdlineargs.h (2 lines)
D	M	src/kreplacements/kcolorbutton.h (2 lines)
D	M	src/kreplacements/kcomponentdata.h (2 lines)
D	M	src/kreplacements/kconfig.h (2 lines)
D	M	src/kreplacements/kdialogbase.h (2 lines)
D	M	src/kreplacements/kedittoolbar.h (2 lines)
D	M	src/kreplacements/kfiledialog.h (2 lines)
D	M	src/kreplacements/kfontdialog.h (2 lines)
D	M	src/kreplacements/kglobal.h (2 lines)
D	M	src/kreplacements/kiconloader.h (2 lines)
D	M	src/kreplacements/kinstance.h (2 lines)
D	M	src/kreplacements/kio/copyjob.h (2 lines)
D	M	src/kreplacements/kio/global.h (2 lines)
D	M	src/kreplacements/kio/job.h (2 lines)
D	M	src/kreplacements/kio/jobclasses.h (2 lines)
D	M	src/kreplacements/kio/jobuidelegate.h (2 lines)
D	M	src/kreplacements/klibloader.h (2 lines)
D	M	src/kreplacements/klocale.h (2 lines)
D	M	src/kreplacements/kmainwindow.h (2 lines)
D	M	src/kreplacements/kmenu.h (2 lines)
D	M	src/kreplacements/kmenubar.h (2 lines)
D	M	src/kreplacements/kmessagebox.h (2 lines)
D	M	src/kreplacements/konq_popupmenu.h (2 lines)
D	M	src/kreplacements/kpagedialog.h (2 lines)
D	M	src/kreplacements/kparts/factory.h (2 lines)
D	M	src/kreplacements/kparts/mainwindow.h (2 lines)
D	M	src/kreplacements/kparts/part.h (2 lines)
D	M	src/kreplacements/kprinter.h (2 lines)
D	M	src/kreplacements/kprogress.h (2 lines)
D	M	src/kreplacements/kprogressdialog.h (2 lines)
D	M	src/kreplacements/kreplacements.h (617 lines)
D	M	src/kreplacements/kreplacements.cpp (1189 lines)
D	M	src/kreplacements/kshortcutsdialog.h (2 lines)
D	M	src/kreplacements/kstandardaction.h (2 lines)
D	M	src/kreplacements/kstandarddirs.h (2 lines)
D	M	src/kreplacements/kstatusbar.h (2 lines)
D	M	src/kreplacements/ktemporaryfile.h (2 lines)
D	M	src/kreplacements/ktoggleaction.h (2 lines)
D	M	src/kreplacements/ktoolbar.h (2 lines)
D	M	src/kreplacements/kunload.h (2 lines)
D	M	src/kreplacements/kurl.h (2 lines)
M		src/main.cpp (34 lines)
M		src/optiondialog.cpp (147 lines)

Commit	Tree	Parents	Author	Summary	Date
43ab342614bd	7237633e6c6d	c194285a96ab	Pino Toscano	Remove unused kreplacements bits (Show More…)	Jun 5 2018, 6:58 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	35586	c194285		Jun 5 2018, 7:02 AM	★	★

Remove unused kreplacements bitsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 35586

src/ccInstHelper.cpp

src/kreplacements/README

src/kreplacements/ShellContextMenu.h

src/kreplacements/ShellContextMenu.cpp

src/kreplacements/config-kdiff3.h

src/kreplacements/kaboutdata.h

src/kreplacements/kaccel.h

src/kreplacements/kaction.h

src/kreplacements/kactioncollection.h

src/kreplacements/kapplication.h

src/kreplacements/kcmdlineargs.h

src/kreplacements/kcolorbutton.h

src/kreplacements/kcomponentdata.h

src/kreplacements/kconfig.h

src/kreplacements/kdialogbase.h

src/kreplacements/kedittoolbar.h

src/kreplacements/kfiledialog.h

src/kreplacements/kfontdialog.h

src/kreplacements/kglobal.h

src/kreplacements/kiconloader.h

src/kreplacements/kinstance.h

src/kreplacements/kio/copyjob.h

src/kreplacements/kio/global.h

src/kreplacements/kio/job.h

src/kreplacements/kio/jobclasses.h

src/kreplacements/kio/jobuidelegate.h

src/kreplacements/klibloader.h

src/kreplacements/klocale.h

src/kreplacements/kmainwindow.h

src/kreplacements/kmenu.h

src/kreplacements/kmenubar.h

src/kreplacements/kmessagebox.h

src/kreplacements/konq_popupmenu.h

src/kreplacements/kpagedialog.h

src/kreplacements/kparts/factory.h

src/kreplacements/kparts/mainwindow.h

src/kreplacements/kparts/part.h

src/kreplacements/kprinter.h

src/kreplacements/kprogress.h

src/kreplacements/kprogressdialog.h

src/kreplacements/kreplacements.h

src/kreplacements/kreplacements.cpp

src/kreplacements/kshortcutsdialog.h

src/kreplacements/kstandardaction.h

src/kreplacements/kstandarddirs.h

src/kreplacements/kstatusbar.h

src/kreplacements/ktemporaryfile.h

src/kreplacements/ktoggleaction.h

src/kreplacements/ktoolbar.h

src/kreplacements/kunload.h

src/kreplacements/kurl.h

src/main.cpp

src/optiondialog.cpp

Remove unused kreplacements bits
ClosedPublic
Actions

Revision Contents
Changeset List