Differential D13293

Provide timezone offset for OFX import
ClosedPublic
Actions

Authored by tbaumgart on Jun 3 2018, 8:11 AM.

Details

Reviewers
ostroffjh
Commits
R261:68a686716680: Provide timezone offset for OFX import
Summary

In certain constellations the post date could be off by one day. This
can happen, when your institution provides timestamps that differ from
the one of your local time. This change allows to adjust the timestamps
during import so that the date will be shown correct.

The new setting can be used to adjust the timestamps of the transactions
during import to reflect your local time. It does not affect previously
imported transactions. The offset is formatted as HH:MM.

If you are located west of your bank's server than enter a negative
time, in case you are located east of it enter a positve time.

If you are not sure, leave this setting at 0:00.

See also: https://forum.kde.org/viewtopic.php?f=69&t=152300


This shows the new setting with an offset of -3 hours.

Test Plan

Requirement is to have an OFX server in different timezone.
Make sure to import a transaction that shows the problem of a post date
off by one day.
Delete the transaction in question.
Setup the correction value in the new account online setting and import.
Repeat the import and verify that the post date is now correct.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tbaumgart requested review of this revision.Jun 3 2018, 8:11 AM
tbaumgart created this revision.
tbaumgart edited the summary of this revision. (Show Details)Jun 3 2018, 8:17 AM
ostroffjh added a comment.Jun 11 2018, 9:28 PM

I assume the summary should have said different timezone, not different timestamp? I do not have that situation, so I'm not sure I can test, other than to compile and to confirm it does not cause any problems.

ostroffjh added a comment.Jun 11 2018, 9:31 PM

Suggestion for improved wording for the first sentence in the tooltip in konlinebankingstatusdecl.ui "If the server is located in a different timezone than your local time, then the post date of imported transactions could be off by a day." (I tried to make as an inline comment, but it does not appear to have worked.)

tbaumgart retitled this revision from Provide timestamp offset for OFX import to Provide timezone offset for OFX import.Jun 12 2018, 6:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2018, 6:14 PM
Closed by commit R261:68a686716680: Provide timezone offset for OFX import (authored by tbaumgart). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36066

View Options

kmymoney/plugins/ofx/import/dialogs/konlinebankingstatus.cpp

Loading...
View Options

kmymoney/plugins/ofx/import/dialogs/konlinebankingstatusdecl.ui

Loading...
View Options

kmymoney/plugins/ofx/import/ofximporter.cpp

Loading...