Differential D13262

[effects/glide] Fix undesired perspective distortions
AbandonedPublic
Actions

Authored by zzag on Jun 1 2018, 10:05 AM.

Details

Reviewers
None
Group Reviewers
KWin
Plasma
Summary

If animated window is near viewport edges, perspective projection
distorts it in undesired way. To fix that, glide effect moves the
window to the origin, "applies" perspective projection, and moves
it back.

That's not the greatest way to fix this bug, but it works.

BUG: 394245

Before

After

Test Plan
  • Moved dolphin to the left side of screen
  • Closed it
  • Didn't see any undesired distortions

Diff Detail

Repository
R108 KWin
Branch
effects-glide-perspective-distortion
Lint
No Linters Available
Unit
No Unit Test Coverage
zzag created this revision.Jun 1 2018, 10:05 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 1 2018, 10:05 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 1 2018, 10:05 AM
zzag edited the summary of this revision. (Show Details)Jun 1 2018, 10:06 AM
zzag added a comment.EditedJun 4 2018, 9:12 AM

FWIW, it doesn't solve the problem 100%. Because the glide effect is doing scale and translation, there is still slight undesired distortion, which is hard to see. It would be great to translate windows in Z direction instead of doing hacky scale and then translation.

zzag abandoned this revision.Jun 4 2018, 4:33 PM

Superseded by D13338.

Revision Contents
Changeset List

PathPackages
Meffects/glide/glide.cpp (25 lines)

Diff 35311

View Options

effects/glide/glide.cpp

Loading...