Port from QScriptEngine to QJSEngine
ClosedPublic
Actions

Authored by ervin on Apr 3 2016, 2:56 PM.

Details

Reviewers

theovaucher
bensi
franckarrecot

Commits

R4:b506e8035e8a: Port from QScriptEngine to QJSEngine

Summary

QtScript being deprecated better use QtQml now. As a nice side-effect,
this fixes the leak we were seeing in the scripthandlertest as QJSEngine
isn't affected.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 3099.Apr 3 2016, 2:56 PM

ervin retitled this revision from to Port from QScriptEngine to QJSEngine.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot, theovaucher.

Mario is so late !!!

This revision is now accepted and ready to land.Apr 3 2016, 3:00 PM

Closed by commit R4:b506e8035e8a: Port from QScriptEngine to QJSEngine (authored by ervin). · Explain WhyApr 3 2016, 3:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/scripting/CMakeLists.txt (2 lines)
M			src/scripting/scripthandler.h (10 lines)
M			src/scripting/scripthandler.cpp (10 lines)
M			src/widgets/CMakeLists.txt (2 lines)
M			tests/features/zanshin/features/step_definitions/CMakeLists.txt (2 lines)
M			tests/units/scripting/scripthandlertest.cpp (10 lines)