Differential D12666

Use security state icon in popup location bar
ClosedPublic
Actions

Authored by anmolgautam on May 2 2018, 3:03 PM.

Details

Reviewers
drosca
Commits
R875:b6edd26ca08c: Use security state icon in popup location bar

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anmolgautam created this revision.May 2 2018, 3:03 PM
Restricted Application added a project: Falkon. · View Herald TranscriptMay 2 2018, 3:03 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
anmolgautam requested review of this revision.May 2 2018, 3:03 PM
drosca requested changes to this revision.May 2 2018, 3:06 PM
drosca added inline comments.
src/lib/popupwindow/popuplocationbar.h
49

Just bool state, you should not use const-ref for POD (plain old data) types.

This revision now requires changes to proceed.May 2 2018, 3:06 PM
anmolgautam updated this revision to Diff 33500.May 2 2018, 3:10 PM

updated revision

drosca accepted this revision.May 2 2018, 3:18 PM
This revision is now accepted and ready to land.May 2 2018, 3:18 PM
Closed by commit R875:b6edd26ca08c: Use security state icon in popup location bar (authored by anmolgautam). · Explain WhyMay 2 2018, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33504

View Options

src/lib/popupwindow/popuplocationbar.h

Loading...
View Options

src/lib/popupwindow/popuplocationbar.cpp

Loading...
View Options

src/lib/popupwindow/popupwindow.cpp

Loading...