Differential D1258

Using KDE Applications version number in Cantor version number
ClosedPublic
Actions

Authored by filipesaraiva on Mar 30 2016, 1:11 AM.

Details

Reviewers
aacid
Summary

Hello @aacid and Release Team, I pushed this patch to Cantor in master branch and all looks like ok. I would like to push it to 16.04 branch too. Is there any problem to push it in this time? Thanks!

Diff Detail

Repository
R55 Cantor
Lint
Lint Skipped
Unit
Unit Tests Skipped
filipesaraiva updated this revision to Diff 3019.Mar 30 2016, 1:11 AM
filipesaraiva retitled this revision from to Using KDE Applications version number in Cantor version number.
filipesaraiva updated this object.
filipesaraiva edited the test plan for this revision. (Show Details)
filipesaraiva added a reviewer: aacid.
filipesaraiva set the repository for this revision to R55 Cantor.
filipesaraiva added a project: Cantor.
filipesaraiva added subscribers: Cantor, aacid.
aacid edited edge metadata.Mar 30 2016, 11:46 PM

I can't see any problem.

filipesaraiva added a comment.Apr 5 2016, 5:06 PM

Hi @aacid, please could you to accept this review? So I will can to close it. :)
Thanks.

aacid accepted this revision.Apr 5 2016, 9:03 PM
aacid edited edge metadata.

I am not convinced you need me to approve it so you can close it but anyway

This revision is now accepted and ready to land.Apr 5 2016, 9:03 PM
filipesaraiva closed this revision.Apr 6 2016, 12:24 AM

Yes, the Close Revision action is available just after some reviewer accept the revision.
Thanks!

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)
Msrc/cantor_part.cpp (2 lines)
Msrc/config-cantor.h.cmake (2 lines)
Msrc/main.cpp (6 lines)

Diff 3019

View Options

CMakeLists.txt

Loading...
View Options

src/cantor_part.cpp

Loading...
View Options

src/config-cantor.h.cmake

Loading...
View Options

src/main.cpp

Loading...