Support deleting ThemeManager after actiongroup and menu, to fix crash in kmail
ClosedPublic

Authored by dfaure on Apr 28 2018, 9:56 AM.

Details

Summary

We used to leak the ThemeManager. Now that we delete it, it crashed
because we delete the action group and the menu first. Add support for
setActionGroup(nullptr) and setThemeMenu(nullptr) so we can clean up while
everything still exists.

Test Plan

Unittest. The actual fix for kmail requires calling these methods
in grantleeheaderstyleplugin.

Diff Detail

Repository
R77 PIM: Grantlee Theme
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 28 2018, 9:56 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 28 2018, 9:56 AM
dfaure requested review of this revision.Apr 28 2018, 9:56 AM
mlaurent accepted this revision.Apr 30 2018, 5:49 AM

Thanks

This revision is now accepted and ready to land.Apr 30 2018, 5:49 AM
dfaure closed this revision.Apr 30 2018, 7:40 AM