kcm_activities: Remove form titles that should not be translatable
AbandonedPublic
Actions

Authored by aspotashev on Mar 27 2016, 4:10 PM.

Details

Reviewers

ivan

Summary

kcm_activities: Make QML-defined UI translatable

Explicitly set translation domain "kcm_activities" in .qml files.

These changes to i18n*() calls do not break string freeze because we
don't change neither msgid nor msgctxt.

Repository

R119 Plasma Desktop

Branch

kcm-activities-i18n-5.6

Lint

No Linters Available

Unit

No Unit Test Coverage

aspotashev retitled this revision from to kcm_activities: Remove form titles that should not be translatable.

aspotashev updated this object.

aspotashev edited the test plan for this revision. (Show Details)

aspotashev added a reviewer: ivan.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Pushed because it's trivial.

Just a note, you do not need to pass changes like these through the review as far as I'm concerned.

(for the activity switcher, kcm and friends - though, I guess, others would not mind i18n fixes for other components to be pushed directly)

			Path	Packages
M			kcms/activities/imports/qml/activityDialog/GeneralTab.qml (12 lines)
M			kcms/activities/imports/qml/activityDialog/OtherTab.qml (2 lines)
M			kcms/activities/imports/qml/activityDialog/components/DialogButtons.qml (4 lines)
M			kcms/activities/imports/qml/activityDialog/components/ShortcutChooser.qml (2 lines)
M			kcms/activities/qml/activitiesTab/ActivitiesView.qml (2 lines)
M			kcms/activities/ui/PrivacyTabBase.ui (3 lines)
M			kcms/activities/ui/SwitchingTabBase.ui (3 lines)

Commit	Tree	Parents	Author	Summary	Date
e0fba278a095	e796832ac245	047613283b4b	Alexander Potashev	kcm_activities: Make QML-defined UI translatable (Show More…)	Mar 27 2016, 3:29 PM
047613283b4b	7780b714732c	fc9a550fbd0c	Alexander Potashev	kcm_activities: Remove form titles that should not be translatable	Mar 27 2016, 3:17 PM