Differential D1204

remove button "more"
ClosedPublic
Actions

Authored by grebois on Mar 23 2016, 10:00 AM.

Details

Reviewers
mlaurent
bensi
Summary

remove the button "more" code

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
grebois updated this revision to Diff 2916.Mar 23 2016, 10:00 AM
grebois retitled this revision from to remove button "more".
grebois updated this object.
grebois edited the test plan for this revision. (Show Details)
grebois added reviewers: mlaurent, bensi.
grebois added a project: KDE PIM: KMail.
mlaurent added inline comments.Mar 24 2016, 6:03 AM
messagelist/src/core/widgets/quicksearchline.h
98 ↗(On Diff #2916)

you forgot to remove all QPushButton which are on quicksearchfilterwidget

grebois added a comment.Mar 24 2016, 10:14 AM

these button ?
QPushButton *mSearchEveryWhere;
QPushButton *mSearchAgainstBody;
QPushButton *mSearchAgainstSubject;
QPushButton *mSearchAgainstFromOrTo;
QPushButton *mSearchAgainstBcc;

and QWidget *mExtraOption; too ?

grebois updated this revision to Diff 2944.Mar 24 2016, 4:56 PM

remove all QPushButton et mextraoption

mlaurent edited edge metadata.Mar 29 2016, 5:55 AM

Autotest is ok now ?

grebois updated this revision to Diff 3007.Mar 29 2016, 3:18 PM
grebois edited edge metadata.

with this modifications in file quicksearchlinetest, autotest works now

mlaurent accepted this revision.Mar 30 2016, 4:26 PM
mlaurent edited edge metadata.

Ok so commit

This revision is now accepted and ready to land.Mar 30 2016, 4:26 PM
mlaurent closed this revision.Feb 17 2018, 2:51 PM

Revision Contents
Changeset List

Diff 3007

View Options

messagelist/autotests/quicksearchlinetest.h

Loading...
View Options

messagelist/autotests/quicksearchlinetest.cpp

Loading...