Fix all warnings in and C++14ify renderer.cpp
Needs ReviewPublic
Actions

Authored by adamniederer on Apr 2 2018, 3:42 AM.

Details

Reviewers

None

Group Reviewers

Summary

This uses C++11 smart pointers in a bunch of locations, fixes a few whitespace issues, and removes float-equality and shadowing warnings from renderer.cpp.

This patch will also work in C++11 if std::make_unique is replaced with a double-allocation or is polyfilled.

Test Plan

This appears to work the same as master with light usage testing (scrubbing, playing, pausing the timeline on a small video).

Diff Detail

Repository

R158 Kdenlive

Lint

Lint Skipped

Unit

Unit Tests Skipped

adamniederer requested review of this revision.Apr 2 2018, 3:42 AM

adamniederer created this revision.

adamniederer edited the summary of this revision. (Show Details)Apr 2 2018, 3:45 AM

adamniederer edited the test plan for this revision. (Show Details)

Thanks for your contribution. your patch mixes several different issue, please in the future try to have one patch for one issue.
We are currently in the middle of a huge code change in Kdenlive. One year of work has been spent in the refactoring_timeline branch that will be merged in 1 month to master. the file renderer.cpp has been completely deleted from the new code, which sadly makes your patch not very useful. The double comparison issue has also been partly solved in this branch using qFuzzyCompare.

If you are interested to contribute, please either wait one month until we merge the new code or have a look at the refactoring_timeline branch.

Regards

Thanks for the heads up. It looks like renderer.cpp exists in the refactoring_timeline branch, though, and a lot of this diff still applies to that file. Would a rebased version be welcome?

https://phabricator.kde.org/source/kdenlive/browse/refactoring_timeline/src/renderer.cpp