Remove unnecessary comment.

Initialize members in the initializer list of the class instead.

I don't think that the name "labelShape" would be too long to be necessary to shorten it.

Remove unnecessary comment.

In this case a switch-case would be more handy in my opinion.

If you don't intend to modify these then you can make them const.

Check the coding style for these lines (spacing in the expressions).

Remove empty line.

Remove empty line.

You should move m_labelShape (instead of m_labelshape) to TextLabelPrivate. That way you won't need any getter, you can just set it in TextLabelPrivate. You should also rename this function to recalcShapeAndBoundingRect(TextLabel::LabelShape) too.

Remove empty line.

There's no need of a second cast, the static_cast does what you wanted. Anyway, this will be reduced to

return m_labelShape;

if you'll change its type to TextLabel.

Remove this function.

Remove unnecessary comment.

Respect our coding style, it should be "Rect = 0"

Why do you use an int instead of the previously declared enum? Using the enum you've created becomes more clear what your parameter is about. (LabelShape)

Getters should be const functions.

This is unnecessary, a single getter is enough for a member variable.

Remove this declaration, can't see any use of it.

Remove unnecessary comment.

Why is this member an int? Its type should be TextLabel.

Not providing a name when using a default argument is a bad practice, the other developers can't deduce what the default parameter means since it has no name. Also the recheck the coding style (space before/after =)

Don't leave the name of the QLabel default. It sould be "lLabel".

Remove unnecessary comment.

Remove unnecessary comment.

Remove unnecessary comment.

This isn't the way you load the configuration. Check the other parameters how they are saved and then loaded here from the config file.

Remove unnecessary comment.

Possible improvement: use const pointer (auto* const label : m_labelsList).

Remove unnecessary comment.

Respect out coding style, the name of this method should be "labelShapeIndexChanged". I think "labelShapeChanged" would do the job too.

Remove empty line.

Remove empty lines.

This should be a const member function.

There's no need of another getter, you have already one:

TextLabel::LabelShape getLabelShape();

This should return

Qt::BrushStyle

because of

Qt::BrushStyle patternStyle;

Make this function const, it's a getter.

Remove this getter, you've got already

TextLabel::LabelShape getLabelShape();

Make this function const, it's a getter.

I think this should be

QColor backgroundColor;

or

QColor fillColor;

This should be:

void chooseLabelBackgroundColor(const QColor&);

or

void chooseLabelFillColor(const QColor&);

(pass const reference to avoid copy constrution)

Here too, pass const reference

const QColor&

This should be

void choosePatternStyle(const Qt::BrushStyle);

because

Qt::BrushStyle patternStyle;

This should return

Qt::BrushStyle

because

Qt::BrushStyle patternStyle;

Move these members to TextLabelPrivate.

Revert this change.

Revert this change too, it shouldn't be removed.

The name of this widget should be

bBackgroundColor

or

bFillColor

The name of this widget should be

cbBackgroundPattern

or

cbFillPattern

These combobox items/styles/patterns should all start with an upper-case letter.

Remove extra space after

SLOT(

The parameter name should start with a lower-case letter.

Use const pointer:

for (auto* const label

Const pointer here too.

No need to cast to QObject*, ui.cbLabelsShape inherits QObject too.

Const pointer.

This object can be const if you don't intend to change it in the future.

No use of this else.

Const pointer.

backcolor can be const.

There's no need of a cast, backcolor it's a QColor already.

Const pointer.

Neither here has any use to have this else here.

Const pointer.

It should be

void labelShapeChanged(int);

It should be

void labelShapePreview(int);

What does this represent? The name isn't very self-describing.

It should be

void labelShapeIndexChanged(int);

The same applies for the other functions you've introduced, they start with upper-case "L".

I don't think so, because then i'll need a plus set of set-get functions

I'll rather use const int getLabelShapeint();
and delete
TextLabel::LabelShape getLabelShape();

I'll pass if possible, i'll need unnecessarily an additional set/get function pair

can't manage to solve it

a copy of the temporary shape, i think it's quite clear

That's not a problem. The main idea I have here is that you use labelShape in TextLabelPrivate, and not in TextLabel, this implies that labelShape should be a member of TextLabelPrivate, not TextLabel. So I suggest you to make this change. The same applies to the other parameters you've added, like backgroundColor, borderStyle, etc, they all belong to TextLabelPrivate. TextLabel can access them through the d pointer, if needed you can write getters and setters for them.

Since labelShape has the type of TextLabel::LabelShape your getter should look like

TextLabel::LabelShape getLabelShape() const;

I think m_previewTempLabelShape would be more self-describing in this case.