Added "bin/" on .gitignore
Details
Diff Detail
- Repository
- R875 Falkon
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Please view the inline comments and also use indentation using 4 spaces.
src/lib/app/mainapplication.cpp | ||
---|---|---|
308–316 ↗ | (On Diff #29220) | This doesn't changes anything but spaces. Please remove it from the diff. |
src/lib/app/mainapplication.h | ||
134 ↗ | (On Diff #29220) | Please use 4 spaces for indentation, also IMO this is not needed, Falkon already has void PluginProxy::emitMainWindowCreated(BrowserWindow* window) |
Have you seen RunAction Python extension that I have added few weeks ago? You should be able to achieve the same thing as this plugin (except the config options) with simple config file (.desktop).
Now that Python extensions are supported, I'd prefer to use C++ only in cases where it is needed and/or it makes more sense than Python. But for a simple extensions like this one, scripted (currently only Python is supported) extensions should always be used if possible. Scripted extensions also make it possible to host the third party extensions somewhere and add option for users to download them, opposite to having them in main Falkon repository.