When When encountering a file with an issue the program iterates through available projects to try to find which project the file is part of.
As implemented, the last project in project list is selected.
Fix this with a proper test inside loop and exit on success.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Could you maybe refactor that code altogether? ProjectPath is quite pointless anyway. It's never read in kdev-cppcheck, only ProjectPath + ErrorFile is used.
My idea: Get rid off ProjectPath, just *always* store the absolute path in ErrorFile. IMO we don't even need findProjectForUrl at all. If you do run cppcheck /path/fo/file.cpp (what we do), then the resulting XML always contains the absolute path anyway.
And: If you could write a basic unit test for the parser, that would be awesome as well! It's trivial to do, just get a sample cppcheck output, parse that, and check whether the CppcheckParser::problems() returns the right things.
Awesome, thanks! Keep up the good work. Then we can eventually merge kdev-cppcheck into kdevelop.git, finally...