Differential D1110

Don't reinvent the wheel.
ClosedPublic
Actions

Authored by parolanilsson on Mar 10 2016, 6:09 PM.

Tags

None

Subscribers

Details

Reviewers

Commits

R61:42e67e1a55bc: Don't reinvent the wheel.
R32:42e67e1a55bc: Don't reinvent the wheel.

Diff Detail

Repository

R61 KDevelop: CppCheck Integration

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

parolanilsson updated this revision to Diff 2671.Mar 10 2016, 6:09 PM

parolanilsson retitled this revision from to Don't reinvent the wheel..

parolanilsson updated this object.

parolanilsson edited the test plan for this revision. (Show Details)

parolanilsson added a reviewer: kfunk.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 10 2016, 6:09 PM

Much better!

job.cpp
120 ↗	(On Diff #2671)	Nitpick: Just remove the temporary variable.

This revision is now accepted and ready to land.Mar 10 2016, 6:11 PM

Do you have commit access?

Nope

Fix issue with kdev-cppcheck selecting wrong project

That last diff was meant to be a separate revision. Don't know how to undo.

Fix issue with kdev-cppcheck selecting wrong project
Undo last commit
Get rid of temporary variable

parolanilsson requested a review of this revision.Mar 10 2016, 6:57 PM

parolanilsson edited edge metadata.

kfunk mentioned this in D1108: Fix "cppcheck: error: unrecognized command line option".Mar 10 2016, 7:45 PM

Closed by commit R61:42e67e1a55bc: Don't reinvent the wheel. (authored by parolanilsson, committed by kfunk). · Explain WhyMar 11 2016, 12:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			job.cpp (6 lines)
M			parsers/cppcheckparser.cpp (5 lines)

Diff 2672

job.cpp

Loading...

parsers/cppcheckparser.cpp

Loading...