Differential D1110

Don't reinvent the wheel.
ClosedPublic
Actions

Authored by parolanilsson on Mar 10 2016, 6:09 PM.

Details

Reviewers
kfunk
Commits
R61:42e67e1a55bc: Don't reinvent the wheel.
R32:42e67e1a55bc: Don't reinvent the wheel.

Diff Detail

Repository
R61 KDevelop: CppCheck Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
parolanilsson updated this revision to Diff 2671.Mar 10 2016, 6:09 PM
parolanilsson retitled this revision from to Don't reinvent the wheel..
parolanilsson updated this object.
parolanilsson edited the test plan for this revision. (Show Details)
parolanilsson added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 10 2016, 6:09 PM
kfunk accepted this revision.Mar 10 2016, 6:11 PM
kfunk edited edge metadata.

Much better!

job.cpp
121

Nitpick: Just remove the temporary variable.

This revision is now accepted and ready to land.Mar 10 2016, 6:11 PM
kfunk added a comment.Mar 10 2016, 6:11 PM

Do you have commit access?

parolanilsson updated this revision to Diff 2672.Mar 10 2016, 6:24 PM
parolanilsson edited edge metadata.
  • Fix issue with kdev-cppcheck selecting wrong project
parolanilsson added a comment.Mar 10 2016, 6:29 PM

That last diff was meant to be a separate revision. Don't know how to undo.

parolanilsson updated this revision to Diff 2674.Mar 10 2016, 6:55 PM
  • Fix issue with kdev-cppcheck selecting wrong project
  • Undo last commit
  • Get rid of temporary variable
parolanilsson requested a review of this revision.Mar 10 2016, 6:57 PM
parolanilsson edited edge metadata.
Closed by commit R61:42e67e1a55bc: Don't reinvent the wheel. (authored by parolanilsson, committed by kfunk). · Explain WhyMar 11 2016, 12:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mjob.cpp (2 lines)

Diff 2689

View Options

job.cpp

Loading...