Differential D1101

Fix segfault when QtQuick isn't available
ClosedPublic
Actions

Authored by pferreira on Mar 10 2016, 9:48 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R33:be9247a96344: Fix segfault when QtQuick isn't available
R32:be9247a96344: Fix segfault when QtQuick isn't available
Summary

For some reason, my Kdev doesn't find qtquick (even though its installed), but that's peripheral to the problem here.

This trivial patch fixes the issue.

KDevelop crashes with the (shortened) back trace:

#5 <signal handler called>
#6 QQuickItem::height (this=0x0) at items/qquickitem.cpp:6234
#7 0x00007f096fd062dd in AssistantPopup::updateLayout() (this=0x4d3c080) at /home/pedro.ferreira/src/kdev/kdevplatform/shell/assistantpopup.cpp:336
#8 0x00007f096fd06425 in AssistantPopup::eventFilter(QObject*, QEvent*) (this=0x4d3c080, object=<optimized out>, event=0x7ffe6fcc8b20) at /home/pedro.ferreira/src/kdev/kdevplatform/shell/assistantpopup.cpp:259
#9 0x000000300883dbdd in QCoreApplicationPrivate::sendThroughObjectEventFilters (this=this@entry=0x187d3f0, receiver=receiver@entry=0x90c23a0, event=event@entry=0x7ffe6fcc8b20) at kernel/qcoreapplication.cpp:1072
#10 0x000000300bb5ae7c in QApplicationPrivate::notify_helper (this=this@entry=0x187d3f0, receiver=receiver@entry=0x90c23a0, e=e@entry=0x7ffe6fcc8b20) at kernel/qapplication.cpp:3712
#11 0x000000300bb5ffb0 in QApplication::notify (this=0x7ffe6fccac50, receiver=0x90c23a0, e=0x7ffe6fcc8b20) at kernel/qapplication.cpp:3499
#12 0x000000300883d9bd in QCoreApplication::notifyInternal (this=0x7ffe6fccac50, receiver=receiver@entry=0x90c23a0, event=event@entry=0x7ffe6fcc8b20) at kernel/qcoreapplication.cpp:965
#13 0x000000300bb93bdc in QCoreApplication::sendEvent (event=0x7ffe6fcc8b20, receiver=0x90c23a0) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:224

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pferreira updated this revision to Diff 2654.Mar 10 2016, 9:48 AM
pferreira retitled this revision from to Fix segfault when QtQuick isn't available.
pferreira updated this object.
pferreira edited the test plan for this revision. (Show Details)
pferreira added a reviewer: KDevelop.
pferreira set the repository for this revision to R33 KDevPlatform.
pferreira added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 10 2016, 9:48 AM
kfunk accepted this revision.Mar 10 2016, 9:51 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Please fix indentation.

This revision is now accepted and ready to land.Mar 10 2016, 9:51 AM
pferreira updated this revision to Diff 2655.Mar 10 2016, 9:54 AM
pferreira edited edge metadata.

I accidentally left a tab instead of spaces for indentation.

Closed by commit R33:be9247a96344: Fix segfault when QtQuick isn't available (authored by kfunk). · Explain WhyMar 10 2016, 10:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/assistantpopup.cpp (5 lines)

Diff 2656

View Options

shell/assistantpopup.cpp

Loading...