Differential D10976

Fix stuck notifications in the share plugin
ClosedPublic
Actions

Authored by kDomb on Mar 2 2018, 8:09 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:0b0b90f778fc: Fix stuck notifications in the share plugin
Summary

Android has a rate limit for updating notifications which was reduced
from 50 to 10 updates/sec since Nougat.
The share plugin updates the progress every time the percentage changes.
The final notification update which makes the notification removable,
is ignored if this happens more than 10 times in a second.
This patch reduces the progress updates to a maximum of 10 times per second.
BUG: 391059

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kDomb requested review of this revision.Mar 2 2018, 8:09 PM
kDomb created this revision.
nicolasfella accepted this revision.Mar 2 2018, 11:01 PM
nicolasfella added a subscriber: nicolasfella.

Thanks!

I can't reproduce the issue, but I can't spot any regressions either.

Do you have commit rights?

This revision is now accepted and ready to land.Mar 2 2018, 11:01 PM
kDomb added a comment.Mar 3 2018, 8:22 AM

I don't have commit rights.

Closed by commit R225:0b0b90f778fc: Fix stuck notifications in the share plugin (authored by kDomb, committed by nicolasfella). · Explain WhyMar 3 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28482

View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...