Differential D10886

Fix name of desktop file
ClosedPublic
Actions

Authored by vanini on Feb 27 2018, 1:03 PM.

Details

Reviewers
sitter
Commits
R550:ee62b9731878: Fix name of desktop file
Summary

This also fixes the window icon in Wayland.

BUG: 382538

Diff Detail

Repository
R550 Muon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vanini requested review of this revision.Feb 27 2018, 1:03 PM
vanini created this revision.
sitter added a comment.Feb 28 2018, 11:13 AM

I suggest you also get an appdata file started https://community.kde.org/Guidelines_and_HOWTOs/AppStream

Notably this should have

​<provides>
​  <id>muon.desktop</id>
​</provides>

currently the appdata is autogenerated from the desktop file. When renaming it's wise to back-reference the previous appstream id though and for that you need an actual appdata file.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-provides

Other than that LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 11:15 AM
Closed by commit R550:ee62b9731878: Fix name of desktop file (authored by vanini). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28915

View Options

src/CMakeLists.txt

Loading...
View Options

src/muon.desktop

Loading...
View Options

src/org.kde.muon.desktop

Loading...