Differential D10574

Add Users button and show room's users when clicked on
ClosedPublic
Actions

Authored by mlaurent on Feb 16 2018, 9:56 AM.

Details

Reviewers
plemire
Commits
R865:8483b1f4e317: Add Users button and show room's users when clicked on

Diff Detail

Repository
R865 Ruqola
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
plemire requested review of this revision.Feb 16 2018, 9:56 AM
plemire created this revision.
mlaurent requested changes to this revision.Feb 16 2018, 12:13 PM
mlaurent added a subscriber: mlaurent.

Otherwise I tested it and it's ok for me.

src/qml/MainComponent.qml
78

I think that we can replace text by icon
iconName: "system-users"

it avoids that translated text takes too many place.

This revision now requires changes to proceed.Feb 16 2018, 12:13 PM
plemire updated this revision to Diff 27336.Feb 16 2018, 1:12 PM

Remove text and use proper icon

mlaurent accepted this revision.Feb 16 2018, 1:14 PM

Thanks a lot :)

This revision is now accepted and ready to land.Feb 16 2018, 1:14 PM
mlaurent commandeered this revision.Feb 16 2018, 6:23 PM
mlaurent edited reviewers, added: plemire; removed: mlaurent.
This revision now requires review to proceed.Feb 16 2018, 6:23 PM
mlaurent updated this revision to Diff 27389.Feb 17 2018, 8:58 AM
  • Fix typo
This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2018, 8:59 AM
Closed by commit R865:8483b1f4e317: Add Users button and show room's users when clicked on (authored by mlaurent). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/ActiveChat.qml (1 line)
Msrc/qml/MainComponent.qml (42 lines)

Diff 27390

View Options

src/qml/ActiveChat.qml

Loading...
View Options

src/qml/MainComponent.qml

Loading...