Hey,
With this patch user will be able to remove an existing Mount point, (Partition -> Edit Mount Point -> Remove) . This will be followed by the same warning message that is displayed when the user saves the changes .
<Edit>
Resolved the comment issue mentioned in review
<Edit>
~abhijeet
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/gui/editmountpointdialog.h | ||
|---|---|---|
| 42 | I think the code would be more readable if instead of int we used enum | |
| src/gui/editmountpointdialogwidget.h | ||
|---|---|---|
| 79 | Is this not used anymore? I think we still need it. | |
| src/gui/editmountpointdialogwidget.cpp | ||
|---|---|---|
| 164 | I'll fix this myself but this fstabEntries() is non-const, so your Qt container will detach and perform deep copy. With Qt containers you should iterate over const containers. | |
| src/gui/editmountpointdialogwidget.cpp | ||
|---|---|---|
| 164 | Hmm, sorry, looks like we can't use const container here precisely because we remove item from the container. | |