spectacle use wrong icon
ClosedPublic
Actions

Authored by andreask on Feb 1 2018, 10:15 PM.

Details

Reviewers

ngraham

Group Reviewers

Spectacle

Commits

R166:c3f89d5be6a8: spectacle use wrong icon

Summary

spectacle use mimetype icon for an action
BUG: 389775

Repository

R166 Spectacle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

andreask requested review of this revision.Feb 1 2018, 10:15 PM

andreask created this revision.

Before-and-after screenshots, please?

see bug report there you have the before screenshot. as I didn't compile anything I can't show you the after screenshot.

andreask added a reviewer: Spectacle.

andreask added a subscriber: Spectacle.

Works perfectly. More appropriate icon, too.

This revision is now accepted and ready to land.Feb 1 2018, 10:21 PM

do I have to do something or is it already in master?

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/Gui/ExportMenu.cpp (2 lines)
M			src/Gui/KSMainWindow.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26354			Feb 1 2018, 10:14 PM	★	★
Diff 2	26355	c6a7671	R166:c3f89d5be6a8abe7b75c1259448562a8cc9ecfd8	Feb 1 2018, 10:30 PM	★	★