Differential D10062

Fix some complicated plural messages
ClosedPublic
Actions

Authored by safaalfulaij on Jan 23 2018, 9:50 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R78:92a5fc9d780a: Fix some complicated plural messages
Test Plan

Not tested

Diff Detail

Repository
R78 PIM: Incidence Editor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
safaalfulaij created this revision.Jan 23 2018, 9:50 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 23 2018, 9:50 PM
safaalfulaij requested review of this revision.Jan 23 2018, 9:50 PM
mlaurent requested changes to this revision.Jan 24 2018, 5:50 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/incidencealarm.cpp
311

Assign directly QString
why create it and after assign it ?

This revision now requires changes to proceed.Jan 24 2018, 5:50 AM
safaalfulaij updated this revision to Diff 25859.Jan 24 2018, 6:11 AM

Fix leftover from previous diff

safaalfulaij added inline comments.Jan 24 2018, 6:13 AM
src/incidencealarm.cpp
311

You're right, I was checking the “Programmer’s Guide” and just blindly copied the same concept (while the case is different)

mlaurent accepted this revision.Jan 24 2018, 6:36 AM

Thanks

This revision is now accepted and ready to land.Jan 24 2018, 6:36 AM
Closed by commit R78:92a5fc9d780a: Fix some complicated plural messages (authored by safaalfulaij). · Explain WhyJan 24 2018, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/incidencealarm.cpp (91 lines)

Diff 25860

View Options

src/incidencealarm.cpp

Loading...