Differential D21978

RFC: Fix search not returning results in Kickoff when cursor is below tabbar
AbandonedPublic
Actions

Authored by filipf on Jun 21 2019, 11:15 PM.

Details

Reviewers
hein
ngraham
Group Reviewers
Plasma
Summary

This is just a speculative fix for the cited bug.

BUG: 401861

Test Plan

Positioned cursor between tab bar and panel icon.

Search results were now actually being displayed.

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-kickoff-no-search-results (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13110
Build 13128: arc lint + arc unit
filipf created this revision.Jun 21 2019, 11:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 21 2019, 11:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 21 2019, 11:15 PM
filipf edited the test plan for this revision. (Show Details)Jun 21 2019, 11:17 PM
filipf added reviewers: hein, Plasma, ngraham.
ngraham added a comment.Jun 22 2019, 9:58 AM

This works for me, and doesn't seem to break the triangle filter, but I'd like @hein to take a look since he wrote this code.

hein added a comment.Jun 22 2019, 10:52 AM

That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause.

hein added a comment.Jun 22 2019, 10:54 AM
In D21978#483972, @hein wrote:

That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause.

D21988

filipf abandoned this revision.Jun 22 2019, 11:14 AM
filipf added a comment.Jul 18 2019, 3:02 PM

Ping, I'm still seeing the issue with the other patch landed.

GB_2 added a subscriber: GB_2.Aug 5 2019, 9:01 AM
In D21978#497409, @filipf wrote:

Ping, I'm still seeing the issue with the other patch landed.

Me too.

GB_2 added a comment.Dec 21 2019, 2:37 PM

Can you please try to further investigate this?

filipf added a comment.Dec 21 2019, 4:58 PM
In D21978#581032, @GB_2 wrote:

Can you please try to further investigate this?

I already tried finding some other solution, but this is the best I can do unfortunately. I just run a local copy of Kickoff with this patch to avoid the bug.

Revision Contents
Changeset List

Diff 60276

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...