@Simon: If you add a call 'setAutoDetectLanguageDisabled(true)' to 'BackgroundChecker::changeLanguage' and 'BackgroundChecker::setSpeller', you should be able to take Albert's suggestion into account.

In D26342#619785, @aacid wrote:

without having used Sonnet much, this seems the wrong API to me.

Are you saying that it can happen that you tell Sonnet "use this language" and it goes and say "nah i'll ignore you and do my thing".

Thanks for the patch!

Thanks for the updated patch!

Small fix to the documentation.

I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language.

You are right that in GuessLanguage::identify(const QString &text, const QStringList &suggestionsListIn), if a language without trigrams is not present in 'suggestionsListIn', it will never be 'guessed'.

In D26321#585381, @cullmann wrote:

I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.
You missed to add the line-count to KTextEditor::ViewPrivate::configKeys()

Add "line-count" to KTextEditor::ViewPrivate::configKeys()

I've tried it out and works just fine! :)

In D25244#562817, @cullmann wrote:

Some feedback?
Else I would just try that.
For me it worked fine (obviously).

I've also got access to the partner center now. So, I can handle updates from now on. Thanks again!

Thanks!

Build 566 works fine now.

I've added a patch to disable Sonnet's language auto-detection during the first run of Kile.

Thanks a lot, Christoph - that's very useful.

This issue is also present on Linux.

It's the language autodetection setting.

Kile as such works fine.

In T9584#205878, @cullmann wrote:

Ok, sorry, then we must remove that from the blacklist again.
But interesting enough, this first time wizard tells that it will miss okular, is that just a left-over from the time it was needed?

In T9584#205874, @cullmann wrote:

I tried to install it. Given I have no real experience with TeX stuff on Windows, can't really try it ;=)
I can only say I assume that okular.exe needs to be installed, too, or?

In T9584#204533, @cullmann wrote:

Ah, you could add 150/310/44 icons to the icons folder, btw., that will avoid that we need to have that in the craft blueprints.

In T9584#203728, @cullmann wrote:

Quick look at the code tells me you need to add something like

/**
 * enable high dpi support
 */
QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true);
QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true);

to have real hidpi support on Windows, I think at the moment just the high dpi pixmap stuff is on.
Both should be done before the application is constructed.

In T9584#202896, @cullmann wrote:

Michel, would you be ok with this?
That we get some installer in shape for the store?

Looks good - thanks a lot!

In T10318#182553, @xyquadrat wrote:

I'm fine with that - but I don't think I'll create a new style just for Kile. The intention behind this redesign (and others, such as planned in T10827) was to unify the style of various smaller KDE websites which reinforces the KDE branding (see T9122). If this isn't wanted for Kile, I'll move on to other sites.

In T10318#175542, @xyquadrat wrote:

My idea is to host it under kile.kde.org eventually, but for that I'll need to talk with Sysadmin and set everything up. Right now I simply created a demo hosted on my own server because that was easier and I would not have wasted the precious resources of our sysadmins if in the end the site is not wanted.

whoops - didn't really mean to set it to resolved...

Thanks for your efforts - I like the idea of refreshing the website!

In D17310#387589, @trickyricky26 wrote:

• Make Kile letters a lighter color

In D17310#387633, @alex-l wrote:

I'm the author of this one:

That has been in Breeze for years. Please next time don't wait so much to complain about an icon that being the app launcher one can be easily noticed when updated.

In D17310#385180, @trickyricky26 wrote:

Here are some designs that are more faithful to the original:

This has almost the same letter design as the original. I adjusted it a bit to fit onto the notepad.

@mludwig
What do you think of these designs? Are they close enough to the original to be recognizable?

In T10243#171551, @ngraham wrote:

What is the original icon? This?

In D17310#383350, @ngraham wrote:

Kile folks, are you good with this now? If we don't hear back in a week or two, we'll have to assume yes. :)

In T10243#171488, @ngraham wrote:

In T10243#171486, @aacid wrote:

Regarding Okular, the first is not "Oxygen" icon, it's the Okular icon as we ship it as part of the okular codebase, breeze just decides to overwrite it with a different one.

OK, then the Breeze icon runs afoul of the "Don't destroy the app's existing branding" recommendation in the HIG. https://hig.kde.org/style/icon.html#application-icons

In D17310#370758, @ngraham wrote:

I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no other app does this.

For those reasons, our HIG specifically recommends against this: https://hig.kde.org/style/icon.html?highlight=icons#general-guidelines

Hey, thanks for working on this.

In D15896#338474, @ognarb wrote:

The complexity of this function doen't change before it was:

for char in result: # line 50
    for replace in replaceMap: # line 53
        compare(replace, char)

and now it's

for replace in replaceMap: # line 47
    for char in result: # line 48
        compare(replace, char)

But I found a better way of doing it, with regex

Thanks for the patch!

In D15754#332144, @ognarb wrote:

In D15754#331980, @mludwig wrote:

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

Ok I will change that.

To make myself a little clearer, when you replace an iterator variable (typically called 'i') with a range-loop, can you try to find a better variable name than 'i'? I think it would improve the readability of the code.

One more question, what is the advantage of removing (empty) destructors and replacing them with 'virtual ~Manager() = default;'?

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

In D15711#330689, @aacid wrote:

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows