Deprecate BrowserHostExtension, only used by KHTML
Open, Needs TriagePublic

Related Objects

dfaure created this task.Nov 24 2019, 2:02 PM
dfaure renamed this task from Deprecate BrowserHostExtension, only used by KHTML to Deprecate BrowserHostExtension and BrowserInterface, only used by KHTML.

It looks like these two classes are also used by Konqueror.

dfaure added a comment.Dec 3 2020, 9:42 PM

Yes but only because they are hooks for KHTML.

OK, I'll remove the konqueror code first.

dfaure added a comment.Dec 3 2020, 9:55 PM

Done: https://invent.kde.org/network/konqueror/commit/bfd6ddf5a38f0d21c080a7509d27343ada8aa286

We should keep BrowserInterface after all, it's now used by WebEnginePart too. I'll retitle the task.

dfaure renamed this task from Deprecate BrowserHostExtension and BrowserInterface, only used by KHTML to Deprecate BrowserHostExtension, only used by KHTML.Dec 3 2020, 9:55 PM

I couldn't readily see where konqueror got to the KHTML part; in retrospect, your commit makes sense.

We should keep BrowserInterface after all, it's now used by WebEnginePart too. I'll retitle the task.

So, konqueror lost some weight/old code, and the task was halved, excellent o/

I couldn't readily see where konqueror got to the KHTML part

Very indirectly: via a KMimeTypeTrader query.

So, konqueror lost some weight/old code, and the task was halved, excellent o/

Yep :)

@dfaure is there anything left to do here, besides adding deprecation markers?

nicolasfella moved this task from Backlog to In Progress on the KF6 board.Dec 12 2020, 10:32 PM
nicolasfella moved this task from In Progress to Done on the KF6 board.Dec 14 2020, 5:00 PM